Skip to content

Fix example app disable controls during reward verification#6761

Merged
polmiro merged 1 commit into
mainfrom
admob-verifying-reward-loading-fix
May 11, 2026
Merged

Fix example app disable controls during reward verification#6761
polmiro merged 1 commit into
mainfrom
admob-verifying-reward-loading-fix

Conversation

@polmiro

@polmiro polmiro commented May 11, 2026

Copy link
Copy Markdown
Member

Checklist

  • If applicable, unit tests
  • If applicable, create follow-up issues for purchases-android and hybrids

Motivation

The previous PR merged before the final follow-up fix landed. This patch ensures reward verification is treated as an in-progress state so users cannot trigger state resets that drop verification results.

Description

  • Set Message.Rewarded.verifyingReward to isLoading: true in the AdMob integration sample.
  • This keeps the reward verification toggle and Load button disabled while verification is in flight, matching how other loading states are handled.

Manual validation in sample app:

  • Start a rewarded verification flow and reach the "Verifying reward..." state.
  • Confirm Load and the verification toggle remain disabled until verification completes.

Note

Low Risk
Low risk: a single sample-app UI state flag change that only affects whether controls stay disabled during reward verification.

Overview
Updates the AdMob integration sample’s Message.Rewarded.verifyingReward to set isLoading: true, so the "Verifying reward..." state is treated like other in-progress states.

This keeps the sample UI from re-enabling actions (e.g., Load/toggles) during reward verification, avoiding state resets that could drop verification results.

Reviewed by Cursor Bugbot for commit aa1e13c. Bugbot is set up for automated code reviews on this repo. Configure here.

Mark the verifying reward state as loading so verification controls remain disabled until the reward verification callback completes.
@polmiro polmiro added the pr:fix A bug fix label May 11, 2026
@polmiro polmiro marked this pull request as ready for review May 11, 2026 10:24
@polmiro polmiro requested a review from a team as a code owner May 11, 2026 10:24
@polmiro polmiro added pr:other pr:admob and removed pr:fix A bug fix labels May 11, 2026
@polmiro polmiro changed the title fix: disable controls during reward verification in AdMob sample Fix example app dsable controls during reward verification May 11, 2026
@polmiro polmiro changed the title Fix example app dsable controls during reward verification Fix example app disable controls during reward verification May 11, 2026

@ajpallares ajpallares left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh true! Sorry I missed this!

@polmiro polmiro merged commit 4f7f47a into main May 11, 2026
21 of 45 checks passed
@polmiro polmiro deleted the admob-verifying-reward-loading-fix branch May 11, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants