Remove redundant isVerified from AdMob reward verification result#6760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-androidand hybridsMotivation
RewardVerificationResult.isVerifiedduplicates the information already represented byverifiedReward. Keeping both introduces redundant API surface and can lead to ambiguous usage.Description
RewardVerificationResult.isVerifiedfrom the experimentalRevenueCatAdMobAPI.verifiedReward != nilisFailed == true(andverifiedReward == nil)verifiedRewarddirectly instead ofisVerified.swift test --filter RevenueCatAdMobTestsinAdapterSDKs/RevenueCatAdMob.Note
Low Risk
Low risk: removes a redundant experimental projection property and updates unit tests to check
verifiedRewarddirectly, with no behavioral changes to verification logic.Overview
Removes the experimental
RewardVerificationResult.isVerifiedproperty, relying onverifiedReward != nilto represent successful verification.Updates the AdMob adapter unit tests to stop referencing
isVerifiedand instead assertverifiedRewardpresence/contents for verified outcomes.Reviewed by Cursor Bugbot for commit 2010b21. Bugbot is set up for automated code reviews on this repo. Configure here.