chore: add logging to reward verification#6745
Merged
Merged
Conversation
7c1f45c to
dfa311c
Compare
ajpallares
reviewed
May 7, 2026
| case let .outcome_delivered(outcome, transactionID): | ||
| return "SSV outcome \(outcome) transactionID=\(transactionID)" | ||
| case let .outcome_suppressed(transactionID): | ||
| return "SSV outcome suppressed (token already consumed) transactionID=\(transactionID)" |
Member
There was a problem hiding this comment.
We recently changed the code naming from "SSV" to "Reward Verification". Do we want to keep the "SSV" naming in the logs?
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ace2381. Configure here.
ajpallares
approved these changes
May 7, 2026
Contributor
Author
|
@RCGitBot please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add logging to the AdMob RewardVerification subsystem
Introduces
RewardVerificationStrings— aLogMessage-conforming enum following the core SDK convention — and adds log lines at every meaningful lifecycle point in the SSV pipeline.Checklist
purchases-androidand hybridsNote
Low Risk
Primarily adds log statements and centralized message strings; behavior changes are limited to extra logging on cancellation/suppressed delivery paths and a warning when
Purchasesis not configured.Overview
Adds a centralized
RewardVerificationStrings(LogMessage) set and wires structured logging throughout the AdMob reward verification (SSV) lifecycle.Setup.installnow warns when the RevenueCat SDK isn’t configured, logs successful installation (ad type + transaction ID), and logs/raises an assertion with a clearer message ifcustomRewardTextencoding fails. The polling loop (Poller.run) logs start/attempts/statuses, differentiates transient vs terminal errors, and warns when attempts are exhausted.Dispatcher.runnow logs when outcome delivery is cancelled or suppressed (token already consumed) and logs the delivered outcome before invoking the handler; the oldRewardVerification/Strings.swifthelper was removed in favor of the new logging strings.Reviewed by Cursor Bugbot for commit ef48173. Bugbot is set up for automated code reviews on this repo. Configure here.