[Billing Plans]: Parse platform_product_plan_identifier in offerings response#6738
Merged
Conversation
Contributor
Author
|
@claude please review |
tonidero
approved these changes
May 7, 2026
ajpallares
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Preliminary work required for supporting billing plans in the iOS SDK.
Description
Adds parsing support for
platform_product_plan_identifierinOfferingsResponse.Offering.Package.The new value is exposed internally as the optional
platformProductPlanIdentifier, allowing offerings responses to carry a platform-specific product plan/base plan identifier when present while preservingnilbehavior for responses that omit it.No public API/behavior changes are introduced.
Changes
platformProductPlanIdentifier: String?toOfferingsResponse.Offering.PackageTesting
platform_product_plan_identifierplatform_product_plan_identifierNote
Low Risk
Low risk: adds an optional decoded field to
OfferingsResponse.Offering.Packageand updates tests/fixtures; behavior is unchanged when the key is absent.Overview
Adds support for decoding
platform_product_plan_identifierinto a new optionalplatformProductPlanIdentifieronOfferingsResponse.Offering.Package.Updates all affected test helpers to pass the new argument and adds fixtures + decoding tests covering both presence and absence of the new JSON field.
Reviewed by Cursor Bugbot for commit 1b50b23. Bugbot is set up for automated code reviews on this repo. Configure here.