Fix fullscreen paywall overflow for fill-mode videos#6726
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9203877. Configure here.
JZDesign
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-androidand hybridsMotivation
Fill-mode video components could cause fullscreen paywalls to expand off screen. This happened because the video aspect-ratio layout could grow wider than the available container when presented fullscreen.
Sheet presentation was unaffected.
Resolves: ONCALL-1688
Description
Note
Low Risk
Low risk layout change: constrains video sizing during aspect-ratio layout and adds targeted tests to prevent regression in fullscreen paywalls.
Overview
Prevents fullscreen Paywalls V2 from expanding off-screen when rendering fill-mode video components by constraining the aspect-ratio container to a computed
maxWidth.VideoComponentViewnow computes a clamped (non-negative) max width based on padding/margins/borders and passes it throughFitToAspectRatio, and newVideoComponentViewTestscover the fullscreen width constraint and max-width calculation edge cases.Reviewed by Cursor Bugbot for commit ebd2826. Bugbot is set up for automated code reviews on this repo. Configure here.