Move deploy-purchase-tester after make-release#6725
Merged
ajpallares merged 1 commit intoApr 30, 2026
Conversation
Previously, `deploy-purchase-tester` ran in parallel with `make-release` and was a required dependency of it. As a result, a failure in `deploy-purchase-tester` (which is not critical for the release itself) would cause `make-release` to be cancelled. This moves `deploy-purchase-tester` to run after `make-release` (mirroring `deploy-rct-tester`), and updates `merge-release-pr` to additionally require `deploy-purchase-tester` and `make-admob-release` so the merge only happens once everything has been deployed. Made-with: Cursor
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reorganizes the
deploy-tagCircleCI workflow so thatdeploy-purchase-testerruns aftermake-release(mirroringdeploy-rct-tester), and updatesmerge-release-prto additionally requiredeploy-purchase-testerandmake-admob-release.Motivation
Previously,
deploy-purchase-testerwas listed as a required dependency ofmake-release. This meant that a failure indeploy-purchase-tester(which is not critical for cutting the release itself) would causemake-releaseto be cancelled — see this recent run where adeploy-purchase-testerfailure cancelledmake-release.Changes
deploy-purchase-testernowrequires: make-release(instead of being a prerequisite of it).deploy-purchase-testerfrom therequireslist ofmake-release.revenuecat/merge-release-prnow also requiresdeploy-purchase-testerandmake-admob-release, so the release PR is only merged once everything has been deployed.New dependency graph (deploy-tag workflow)
Testing
This is a CircleCI workflow-only change. The behavior will be exercised on the next release tag.
Made with Cursor
Note
Low Risk
Low risk workflow reordering in CircleCI; main impact is release-tag job dependency/gating changes that could alter when merges/deploys occur if a job fails.
Overview
Reorders the
deploy-tagCircleCI workflow sodeploy-purchase-testerruns aftermake-releaseinstead of blocking it, preventing non-critical tester deployment failures from canceling the release job.Updates
revenuecat/merge-release-prto additionally wait fordeploy-purchase-testerandmake-admob-release, so the release PR merges only after these deployments complete.Reviewed by Cursor Bugbot for commit 8e8fd15. Bugbot is set up for automated code reviews on this repo. Configure here.