Fix workflow page transition layering#6717
Merged
Merged
Conversation
…o codex/codex-20260429-181453 # Conflicts: # RevenueCatUI/Modifiers/EnvironmentValues+Workflow.swift
vegaro
reviewed
Apr 30, 2026
| let pageOffset: CGFloat | ||
| /// Opacity for buttons rendered inside workflow headers. | ||
| /// This crossfades outgoing and incoming header buttons during page transitions. | ||
| let headerButtonOpacity: CGFloat |
Member
There was a problem hiding this comment.
this is interesting. in Android I wasn't crossfading, but it looks good! might add to android as well
vegaro
approved these changes
Apr 30, 2026
2 tasks
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simulator.Screen.Recording.-.iPhone.16e.-.2026-04-30.at.11.03.46.mov
Note
Medium Risk
Adjusts core workflow paywall transition behavior (z-ordering, offsets, opacity) which can impact navigation UX and animation correctness across platforms, though changes are localized and covered by updated tests.
Overview
Fixes workflow page slide transitions so the outgoing page remains on top during animations, preventing blank/flash artifacts.
Introduces a
WorkflowPageTransitionContextpropagated fromWorkflowPaywallViewvia SwiftUI environment and marks header subtrees withisWorkflowHeaderso header buttons can counter-offset (stay visually stationary) and crossfade (headerButtonOpacity) between steps.Updates
WorkflowPaywallViewTeststo assert the new z-index ordering and header button opacity behavior for forward/back transitions.Reviewed by Cursor Bugbot for commit 594a862. Bugbot is set up for automated code reviews on this repo. Configure here.