Fix: Enforce vertical bounds in RootView#6708
Merged
Merged
Conversation
Add a transparent filler view to RootView so the ZStack expands vertically and headers/footers are positioned correctly. Introduces a private fillVerticalBounds property (Color.clear.frame(width: 1)) and inserts it into the ZStack before the StackComponentView to ensure consistent layout across stack dimensions.
bilqisium
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-androidand hybridsMotivation
PWENG-2
Zlayer stacks with headers and footers did not lay out consistently
Description
Add a transparent filler view to RootView so the ZStack expands vertically and headers/footers are positioned correctly. Introduces a private fillVerticalBounds property (Color.clear.frame(width: 1)) and inserts it into the ZStack before the StackComponentView to ensure consistent layout across stack dimensions.
Note
Low Risk
Low risk layout-only change: adds an invisible sizing view so the root
ZStackreliably fills available height, which may subtly affect view sizing but does not touch data, networking, or auth.Overview
Fixes inconsistent header/footer positioning in Paywalls V2 by forcing the
RootViewZStackto expand to the full vertical bounds.Adds a private
fillVerticalBounds(a transparentColor.clearframe) and inserts it into theZStackbefore the mainStackComponentViewso z-layer stacks lay out consistently across different stack dimensions.Reviewed by Cursor Bugbot for commit 2f2f8c8. Bugbot is set up for automated code reviews on this repo. Configure here.