Add id to PaywallButtonComponent#6679
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
vegaro
approved these changes
Apr 23, 2026
This was referenced Apr 23, 2026
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
id: String?toPaywallComponent.ButtonComponent— decoded from JSON, optional, defaults tonilidthroughButtonComponentViewModelas a stored propertyThis is a prerequisite for PR 3 (button workflow trigger actions), where a button with a matching
componentIdin a workflow trigger will emit atriggerWorkflowaction instead of its normal action.Test plan
swift buildpasses (verified locally)iddecodes correctly from JSON when present, isnilwhen absent🤖 Generated with Claude Code
Note
Low Risk
Low risk additive model change: introduces an optional
idfield onPaywallComponent.ButtonComponentand threads it into the UI view model; main impact is on Codable/equality/hash behavior for button components.Overview
Adds an optional
id: String?toPaywallComponent.ButtonComponent, including JSON decoding/encoding and updatingHashable/Equatableto incorporate the new field.Plumbs this identifier through to
ButtonComponentViewModelas a storedid, populated from the underlying component.Reviewed by Cursor Bugbot for commit 507b385. Bugbot is set up for automated code reviews on this repo. Configure here.