chore: Remove unused key from customer center event#4837
Merged
Conversation
ajpallares
approved these changes
Mar 5, 2025
Co-authored-by: Antonio Pallares <ajpallares@users.noreply.github.com>
Member
Author
|
@RCGitBot please test |
1 similar comment
Member
Author
|
@RCGitBot please test |
This was referenced Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We've realized this key is ignored, so better to remove it than to have it there for nothing.
Description
As opposed to the Android implementation, the StoredEvent already stores the encoded event. This makes backwards compatibility so much easier, because once it's stored you can forget about future problems. Editing events is harmless.
There are also integration tests in place, so it's safe to say that this is harmless as well 🚀