[Paywalls V2] Add full cover option to Paywalls Tester#4745
Merged
joshdholtz merged 2 commits intoJan 30, 2025
Conversation
1 build increased size
Paywalls 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| DYLD.String Table | ⬆️ 13.9 kB |
| Code Signature | ⬆️ 936 B |
| DYLD.Exports | ⬆️ 912 B |
| 📝 RCPurchases.applicationDidBecomeActive | ⬆️ 900 B |
| RCPurchases.Objc Metadata | ⬇️ -873 B |
View Treemap
🛸 Powered by Emerge Tools
0ccb313 to
b73ce2f
Compare
eec3175 to
cc82b4f
Compare
ajpallares
reviewed
Jan 30, 2025
| // CI system adds keys here | ||
| extension AvailableConfigItems { | ||
| static var apiKey: String { "" } | ||
| static var apiKey: String { "appl_SYkbbYptqjDadVkQeBUtXxVxCcw" } |
ajpallares
reviewed
Jan 30, 2025
JayShortway
reviewed
Jan 30, 2025
JayShortway
left a comment
Member
There was a problem hiding this comment.
LGTM! No additional comments besides Antonio's.
Comment on lines
+11
to
+16
| enum PaywallTesterViewMode: String { | ||
| case fullScreen = "Full Screen" | ||
| case sheet = "Sheet" | ||
| case footer = "Footer" | ||
| case condensedFooter = "Condensed Footer" | ||
| } |
Member
There was a problem hiding this comment.
More a question to get context than a comment. Are those rawValue coming from somewhere? Like, are those used for decoding / encoding? Because I see the name uses the same strings.
Member
Author
There was a problem hiding this comment.
Ahhh, I was going to use them as a display name in the UI but ended up making with a name variable in the extension instead 😊 Going to remove these!
cc82b4f to
1e2e423
Compare
Base automatically changed from
paywalls-v2/ignore-top-edges-for-image
to
main
January 30, 2025 11:04
1e2e423 to
8abb7fa
Compare
ajpallares
approved these changes
Jan 30, 2025
| .onRestoreCompleted { _ in | ||
| viewModel.dismissPaywall() | ||
| } | ||
| .id(viewModel.presentedPaywall?.hashValue) //FIXME: This should not be required, issue is in Paywallview |
Member
There was a problem hiding this comment.
I hit a similar issue when working on the paywall reload, the reason being:
Which is fine because normally paywall info will not change while it is presented.
MarkVillacampa
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Changes here were made to test #4744
Description
Make a separate full screen for:
Screen.Recording.2025-01-29.at.5.53.51.PM.mov