[Paywalls V2] Support variable mapping#4740
Merged
Merged
Conversation
3e53565 to
0c534f3
Compare
JayShortway
approved these changes
Jan 29, 2025
| private func findVariable(_ variableRaw: String) -> VariablesV2 { | ||
| guard let originalVariable = VariablesV2(rawValue: variableRaw) else { | ||
|
|
||
| let backSupportedVariableRaw = self.variableCompatibilityMap[variableRaw] |
Member
There was a problem hiding this comment.
Wild thought: should this support recursion? E.g. backSupportedVariableRaw is also unsupported, and we go look in the variableCompatibilityMap again to see if there's a backBackSupportedVariableRaw. Probably not right? 😅
Member
Author
There was a problem hiding this comment.
Ha! I don't think it needs to since we are defining this on the backend so we will just never do a recursion thing 🤷
| case productRelativeDiscount = "product.relative_discount" | ||
| case productStoreProductName = "product.store_product_name" | ||
|
|
||
| case unsupported = "__unsupported__" |
Member
There was a problem hiding this comment.
I'd be okay if findVariable and findFunction returned nil if the variable / function is not found, as nil indicates absence of data, but not a blocker.
This was referenced Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Support the backward compatibility variable mapping
Description