Improved JSON format for ButtonComponent codables#4408
Merged
joshdholtz merged 3 commits intoOct 25, 2024
Conversation
JayShortway
reviewed
Oct 25, 2024
JayShortway
left a comment
Member
There was a problem hiding this comment.
Much better, thanks for fixing! Just 1 comment/question on type vs action.
JayShortway
approved these changes
Oct 25, 2024
Comment on lines
+76
to
+83
| { | ||
| "type": "button", | ||
| "action": { | ||
| "type": "navigate_to", | ||
| "destination": "customer_center" | ||
| }, | ||
| "stack": \(jsonStringDefaultStack) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
ButtonComponenthad great looking enums but I just realized that they wouldn't codable the JSON structure that we want them too.Description
Previously...
{ "type": "button", "action": { "navigateTo": { "destination": { "privacyPolicy": { "urlLid": "https://example.com/privacy-policy", "method": "externalBrowser" } } } }, "stack": { "type": "stack", "components": [] } }Now...
{ "type": "button", "action": { "type": "navigate_to", "destination": "privacy_policy", "url": { "urlLid": "https://example.com/terms-of-service", "method": "deepLink" } }, "stack": { "type": "stack", "components": [] } }