[Customer Center] Improve subscription details view#4152
Merged
codykerns merged 5 commits intoAug 8, 2024
Merged
Conversation
codykerns
commented
Aug 7, 2024
| .shadow(color: Color.black.opacity(0.2), radius: 4) | ||
|
|
||
| } | ||
| .padding(24.0) |
Member
Author
There was a problem hiding this comment.
this is entirely subjective, although the corner radius and shadow details below were as well - not sure if we need to pull this out of here
aboedo
approved these changes
Aug 7, 2024
|
|
||
| Button(action: { configuration.trigger() }, label: { | ||
| configuration.label.frame(width: 300) | ||
| configuration.label.frame(maxWidth: .infinity) |
Member
There was a problem hiding this comment.
I was struggling with this, as a full width card didn't look good with the text size I had. Looks much better with the larger text! 🙌
add additional padding for subscription details shadow
JayShortway
approved these changes
Aug 8, 2024
|
|
||
| Button(action: { configuration.trigger() }, label: { | ||
| configuration.label.frame(width: 300) | ||
| configuration.label.frame(maxWidth: .infinity) |
Member
There was a problem hiding this comment.
I was struggling with this, as a full width card didn't look good with the text size I had. Looks much better with the larger text! 🙌
Comment on lines
+380
to
+386
| SubscriptionDetailsView( | ||
| subscriptionInformation: CustomerCenterConfigTestData.subscriptionInformationMonthlyRenewing, | ||
| localization: CustomerCenterConfigTestData.customerCenterData.localization, | ||
| refundRequestStatusMessage: "Success" | ||
| ) | ||
| .previewDisplayName("Subscription Details - Monthly") | ||
| .padding() |
Member
There was a problem hiding this comment.
Nice to have a separate preview!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The subscription details view could take advantage of more available space