[Customer Center] UI polish for empty content#4147
Conversation
|
The code is :chefskiss: and I love how the view looks! Thanks for doing this Cody! We'll have to update snapshots for this (@RevenueCat/coresdk could you remind me how that's done?). I think the only thing that we'll have to figure out is how to make the strings used here localizable, do we already have any of those coming from the backend that we can reuse? (Also question for CoreSDK) |
JayShortway
left a comment
There was a problem hiding this comment.
Love it! 🤩
Regarding localized strings, I believe the idea is to place them in CustomerCenterConfigData.Localization.
Not sure how to update the snapshots though.
(cc @aboedo)
|
This looks nice!
It's been a while but I believe you should be able to trigger it through either fastlane ( As for localization, what @JayShortway mentioned is correct! The idea is to have them as common strings which can be overriden by the backend response, but still have some default in the SDK. |
|
Actually, I believe we don't have snapshot tests for CustomerCenter yet right @aboedo? I believe we are planning to add them but didn't yet |
|
Thanks all! @aboedo since this PR just refactors the already hard-coded strings, should the localization changes be made in a separate PR? |
|
My bad, I'd missed that the strings already existed and that we don't even have snapshots for customer center. |
|
Since the failing test was related to snapshots (that I ran manually), and affects all of customer center currently and not just this PR, going to merge this. Standard tests are succeeding 👍 |
Attempting some UI polish
ContentUnavailableViewfor the views that have 'empty' content (with a visually similar backwards compatible version)