[Customer Center] Fixes an extra blank screen after popping FeedbackSurveyView on iOS 18.#4144
Merged
Conversation
…kflow' into sdk-3519-extra-blank-screen-after-back-button-on-cancel-subscription
tonidero
approved these changes
Aug 6, 2024
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Might be good to get an iOS dev eye on this, but LGTM!
MarkVillacampa
approved these changes
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
The issue in the ticket is caused by the use of
.constantand.onDisappear, which probably resulted in a timing issue where thefeedbackSurveyDatais not set tonilquickly enough after pressing the Back button.Fix
The fix in this PR is to bind directly to the
.feedbackSurveyDataproperty. I've added an.isNotNilBinding extension for this, as it seemed useful to reuse in other parts of RevenueCatUI. Let me know if theBinding+Extensions.swiftfile should be placed somewhere else instead.Closes SDK-3519