[Customer Center] Fix for disabled promo offer button#4142
Merged
vegaro merged 1 commit intoAug 2, 2024
Conversation
tonidero
approved these changes
Aug 2, 2024
| promoOfferDetails: promotionalOfferData.promoOfferDetails) | ||
| }) | ||
| .buttonStyle(ManageSubscriptionsButtonStyle()) | ||
| .disabled(self.viewModel.loadingPath != nil) |
Contributor
There was a problem hiding this comment.
Hmm I'm not sure I understand why doing this before actually fixes this... But I'm ok with the fix 👍
Member
Author
There was a problem hiding this comment.
It's because it applies it to the sheet as well, and the sheet is the one presenting the promo offer, so basically everything in the sheet is disabled
Contributor
There was a problem hiding this comment.
Ahh makes sense. Thanks for explaining!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the purchase button for the promo offers is always disabled. Changing the order of the modifiers fixes it