[Customer Center] Fix checking eligibility#4138
Merged
vegaro merged 2 commits intoJul 31, 2024
Merged
Conversation
tonidero
reviewed
Jul 31, 2024
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Is this ready for review? LGTM so far
| @@ -127,15 +127,20 @@ class ManageSubscriptionsViewModel: ObservableObject { | |||
| } | |||
| } | |||
| case let .promotionalOffer(promotionalOffer): | |||
Contributor
There was a problem hiding this comment.
I've wondering whether it would make sense to filter out the promotional offers before this... But that would require some preprocessing of the config data, so I think this is ok.
Member
Author
There was a problem hiding this comment.
Thought about it as well, but figured this would be the easiest for now
| case .success(let promotionalOfferData): | ||
| self.promotionalOfferData = promotionalOfferData | ||
| case .failure: | ||
| if promotionalOffer.eligible { |
Contributor
There was a problem hiding this comment.
Probably good to add some tests once we have time.
Member
Author
Oh yes, I opened it as draft by mistake 😄 |
tonidero
approved these changes
Jul 31, 2024
Member
Author
|
Added a test to ManageSubscriptionsViewModelTest since it wasn't too complex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were not checking if the user is eligible for the promotional offer before trying to load it