[Customer Center] Move No subscriptions page strings to Localization#4089
Merged
tonidero merged 1 commit intoJul 19, 2024
Conversation
tonidero
commented
Jul 19, 2024
|
|
||
| public func commonLocalizedString(for key: CommonLocalizedString) -> String { | ||
| return self.localizedStrings["common_\(key.rawValue)"] ?? key.defaultValue | ||
| return self.localizedStrings[key.rawValue] ?? key.defaultValue |
Contributor
Author
There was a problem hiding this comment.
This prefix is removed by the backend in the response, so we don't need to use it here.
| case .restoreCompleted(_): | ||
| print("CustomerCenter: restoreCompleted") | ||
| case .purchaseCompleted(_): | ||
| print("CustomerCenter: purchaseCompleted") |
Contributor
Author
There was a problem hiding this comment.
This was a leftover from a last minute change in #4057 which was causing paywall tester not to build.
tonidero
commented
Jul 19, 2024
f1eba27 to
1c9a6fe
Compare
Base automatically changed from
06-17-removes_eligibility_from_reponse
to
integration/customer_support_workflow
July 19, 2024 14:30
1c9a6fe to
54b6370
Compare
vegaro
approved these changes
Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is based on the changes in #3968
This PR:
CustomerCenterConfigData.Localizationobject.common_prefix, which is already removed by the backend.