[Customer Center] Improves the UI of the current subscription#4072
Conversation
…based localizedPriceString.
tonidero
left a comment
There was a problem hiding this comment.
Looks amazing! Just some comments but nothing major
| Text("\(subscriptionInformation.title)") | ||
| .font(.headline) | ||
| Text("\(subscriptionInformation.explanation)") | ||
| .frame(maxWidth: 200, alignment: .leading) |
There was a problem hiding this comment.
Hmm is setting a maxWidth necessary? Not sure if it would be better to set a percentage max width or something like that if it's necessary
There was a problem hiding this comment.
Without this maxWidth, this text would cause the outer card to span the entire width of the (phone) screen, which I think doesn't look great.
I'd be okay setting it to a relative size, but I haven't found an easy way to do so. Some suggest wrapping it all in a GeometryReader, or using a custom Layout. Let me know if you know another way!
I did check maxWidth: 200 on an iPhone SE, and that still looks fine.
| Image(systemName: "coloncurrencysign.arrow.circlepath") | ||
| .frame(width: 22) | ||
| VStack(alignment: .leading) { | ||
| Text("Billing cycle") |
There was a problem hiding this comment.
I guess we will need to extract all these strings so they are provided by the backend and used here, but that can come in a separate PR.
There was a problem hiding this comment.
As discussed on Slack, this will be done in a separate PR.
Co-authored-by: Toni Rico <toni.rico.diez@revenuecat.com>
Summary
This PR improves the presentation of the current subscription.
This PR can be seen as a proposal. Feel free to add any suggestions!
Before
After