Remove restoreStarted from extensions#3698
Merged
Merged
Conversation
Contributor
|
I wouldn't consider this a |
tonidero
approved these changes
Feb 20, 2024
tonidero
left a comment
Contributor
There was a problem hiding this comment.
I guess this is not removed from the VC delegate, but that's probably ok. This looks good. Should we hold this until the other PR is ready or we make a release? (which should happen tomorrow)
joshdholtz
approved these changes
Feb 20, 2024
Member
Author
|
I think we can merge and it's fine to released tomorrow. Hoping to finish that other PR today though. Just wanted to merge this in case we needed to do a release today. |
This was referenced Feb 21, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are deprecating the old function in https://github.com/RevenueCat/purchases-ios/pull/3693/files
I thought it will be simpler to just add both
restoreStartedand the newpurchaseStarted(package:)in the same release. We haven't made a release since I merged #3694 so these are safe to remove for now.I open this PR in case we want to make a release before #3693 is finished.