Fix Chinese localizations#3490
Merged
Conversation
Member
|
@francisfeng thanks for opening this up! |
aboedo
approved these changes
Dec 5, 2023
b43c7f1
into
RevenueCat:andy/deng-621-incorrect-translations-for-paywall-chinese-localization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #3489
Description
Another issue I found after looking at the Localizable.strings: You can’t directly translate "%d%% off” as "%d%%折” in Chinese. In Chinese, if one item is 20% off, we say it’s “8折” (8 comes from (1-20%)*10).
So if you insist on this translation you will need to change the related code. I would suggest you to simply translate "%d%% off" as "优惠%d%%"(Simplified Chinese) and "優惠%d%%" (Traditional Chinese), which aligns with the word ”off”.
Last issue regarding formatting: "Default_offer_details_with_intro_offer" = "开始 {{ sub_offer_duration }} 试用，然后 {{total_price_and_per_month }}。"; I don’t think we need spaces around “{{ sub_offer_duration }}” and ”{{total_price_and_per_month }}”.