Paywalls: enable all iOS 17 tests#3325
Merged
NachoSoto merged 2 commits intoOct 24, 2023
Merged
Conversation
NachoSoto
commented
Oct 23, 2023
Comment on lines
-91
to
-94
| if #available(iOS 17.0, *) { | ||
| try XCTSkipIf(true, "This is currently not working on iOS 17") | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Now we'll be running a lot more tests that were disabled on iOS 17.
NachoSoto
commented
Oct 23, 2023
These were failing in some of the earlier Xcode 15 betas, but they all seem to be passing now. `PresentIfNeededTests` are still not working though. But I just manually verified that these modifiers do work correctly on iOS 17 on an app.
1a16a7c to
0b01f29
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## paywalls-purchase-completed-transaction #3325 +/- ##
==========================================================================
Coverage ? 85.96%
==========================================================================
Files ? 237
Lines ? 17081
Branches ? 0
==========================================================================
Hits ? 14684
Misses ? 2397
Partials ? 0 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were failing in some of the earlier Xcode 15 betas, but they all seem to be passing now.
PresentIfNeededTestsare still not working though. But I just manually verified that these modifiers do work correctly on iOS 17 on an app.