PostReceiptDataOperation: add new testReceiptIdentifier parameter#2749
Merged
Conversation
Yesterday this was added, making this test fail.
…2733) Requested by @NachoSoto for [integration-test-idfv](https://github.com/RevenueCat/purchases-ios/tree/integration-test-idfv) Co-authored-by: Distiller <distiller@static.38.23.39.70.cyberlynk.net>
…2734) Requested by @NachoSoto for [integration-test-idfv](https://github.com/RevenueCat/purchases-ios/tree/integration-test-idfv) Co-authored-by: Distiller <distiller@static.38.39.184.32.cyberlynk.net>
…2736) Requested by @NachoSoto for [integration-test-idfv](https://github.com/RevenueCat/purchases-ios/tree/integration-test-idfv) Co-authored-by: Distiller <distiller@static.38.39.184.87.cyberlynk.net>
…2735) Requested by @NachoSoto for [integration-test-idfv](https://github.com/RevenueCat/purchases-ios/tree/integration-test-idfv) Co-authored-by: Distiller <distiller@static.38.39.183.166.cyberlynk.net>
…2737) Requested by @NachoSoto for [integration-test-idfv](https://github.com/RevenueCat/purchases-ios/tree/integration-test-idfv) Co-authored-by: Distiller <distiller@static.38.39.184.105.cyberlynk.net>
aboedo
approved these changes
Jul 5, 2023
159f1c3 to
d703df1
Compare
PostReceiptDataOperation: add new testReceiptIdentifier parameterintegration test idfvPostReceiptDataOperation: add new testReceiptIdentifier parameter
Codecov Report
@@ Coverage Diff @@
## main #2749 +/- ##
==========================================
+ Coverage 86.41% 86.48% +0.06%
==========================================
Files 214 214
Lines 15265 15265
==========================================
+ Hits 13192 13202 +10
+ Misses 2073 2063 -10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the backend to disambiguate receipts that are coming from different test invocations.
With
SKTestSessionreceipts, the backend has limited information to disambiguate receipts coming from different tests. By adding a new UUID that we can re-generate in each test, we help the backend not mix receipts from separate tests.Note that the value sent in
X-Apple-Device-Identifieris unchanged (and verified with tests) because it's important that this is the realIDFV, since it's used to validateAppleReceipt.sha1Hash.Depends on https://github.com/RevenueCat/khepri/pull/6183