Skip to content

Integration Tests: avoid crashes when printing receipt#2570

Merged
NachoSoto merged 1 commit into
mainfrom
integration-test-crash-receipt
Jun 1, 2023
Merged

Integration Tests: avoid crashes when printing receipt#2570
NachoSoto merged 1 commit into
mainfrom
integration-test-crash-receipt

Conversation

@NachoSoto

Copy link
Copy Markdown
Contributor

Fixes https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/11501/workflows/b978f26f-ce2d-4040-ac40-96e121c4407f/jobs/72997/steps

Same as #2532, this prevents test crashes when this function is called after Purchases has been reset.
Test crashes are inconvenient because it makes the entire test run fail, instead of allowing retries.

@NachoSoto NachoSoto added the test label May 31, 2023
@NachoSoto NachoSoto requested a review from a team May 31, 2023 18:05
Fixes https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/11501/workflows/b978f26f-ce2d-4040-ac40-96e121c4407f/jobs/72997/steps

Same as #2532, this prevents test crashes when this function is called after `Purchases` has been reset.
Test crashes are inconvenient because it makes the entire test run fail, instead of allowing retries.
@NachoSoto NachoSoto force-pushed the integration-test-crash-receipt branch from 33de943 to 3c29411 Compare May 31, 2023 18:06
@codecov

codecov Bot commented May 31, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2570 (3c29411) into main (a18d3b4) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2570      +/-   ##
==========================================
+ Coverage   88.02%   88.04%   +0.01%     
==========================================
  Files         201      201              
  Lines       13997    13997              
==========================================
+ Hits        12321    12323       +2     
+ Misses       1676     1674       -2     

see 2 files with indirect coverage changes

@NachoSoto NachoSoto merged commit 242c402 into main Jun 1, 2023
@NachoSoto NachoSoto deleted the integration-test-crash-receipt branch June 1, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants