Extracted LoggerType#2098
Merged
Merged
Conversation
545629b to
6b73cb6
Compare
This will be used to inject a logger into `ReceiptParser` ([CSDK-17]).
6b73cb6 to
9b659a1
Compare
vegaro
approved these changes
Dec 7, 2022
aboedo
approved these changes
Dec 7, 2022
| import Foundation | ||
|
|
||
| /// A type that can receive logs of different levels. | ||
| protocol LoggerType { |
Member
There was a problem hiding this comment.
this is a pattern that I wish we had used a lot more in the codebase, the inherit + replace approach feels more cumbersome and dangerous to me (dangerous because you could forget to replace a function in the mock and it gets called in the parent)
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be used to inject a logger into
ReceiptParser(CSDK-17).