Async.call method to convert completion-block call to async#1969
Merged
Conversation
cb3caf1 to
407ab4a
Compare
NachoSoto
commented
Oct 7, 2022
Comment on lines
+63
to
+66
| @Sendable | ||
| func complete(_ result: Result<Value, Error>) { | ||
| continuation.resume(with: result) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Without this intermediate func it doesn't compile before Xcode 14.1.
2 tasks
tonidero
approved these changes
Oct 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies calling completion-block APIs as
async. The opposite of what #1943 introduced.