Integration Tests: simplified testIneligibleForIntroAfterPurchaseExpires to fix flakiness#1952
Merged
Merged
Conversation
…xpires` to fix flakiness Fixes [CSDK-479]. ### Changes: - Removed extra `verifyEntitlementWentThrough`. #1880 introduced a change so that weekly subscriptions aren't verified, because they expire within a second. This make the test flaky due to that race condition. - Removed `assertNoActiveSubscription`: I tried calling `SKTestSession.disableAutoRenewForTransaction`, but sometimes the server still thinks the subscription has auto-renewed. This was making the test flaky. Turns out that even if it's not active, the eligibility test still passes as expected.
946fadf to
274097e
Compare
vegaro
approved these changes
Sep 29, 2022
vegaro
left a comment
Member
There was a problem hiding this comment.
I tried calling SKTestSession.disableAutoRenewForTransaction, but sometimes the server still thinks the subscription has auto-renewed.
Is this an issue we should fix?
Contributor
Author
|
I talked about it with @aboedo. The backend has no way of knowing if an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CSDK-479.
Changes:
verifyEntitlementWentThrough.Integration Tests: actually verify that entitlement is active #1880 introduced a change so that weekly subscriptions aren't verified, because they expire within a second. This make the test flaky due to that race condition.assertNoActiveSubscription: I tried callingSKTestSession.disableAutoRenewForTransaction, but sometimes the server still thinks the subscription has auto-renewed. This was making the test flaky. Turns out that even if it's not active, the eligibility test still passes as expected.syncPurchases. It doesn't matter what state the server is in, as long as locallySKTestSessionhas an expired subscription.This, together with #1945, should fix the last of the issues causing flaky integration tests 🤞🏻