Build fix- Update package requirements for MagicWeather#1852
Conversation
pull in up to next major, fix build issue
| repositoryURL = "https://github.com/RevenueCat/purchases-ios.git"; | ||
| requirement = { | ||
| branch = main; | ||
| kind = branch; |
There was a problem hiding this comment.
Hmm honestly I don't know, but will this cause the MagicWeather app to only work with deployed versions of purchases-ios? I think it's nice to test with the local version of purchases-ios, but then again I don't think it's a big deal, so I'm ok with it.
There was a problem hiding this comment.
Oh, that's true. It's already pinned a revision, I was thinking it make sense just to keep it at what our customers would use. PurchaseTester feels like it should be pointed to main, but maybe these sample apps make sense to keep pinned to releases?
There was a problem hiding this comment.
Yeah, I think it's good to keep at least a sample app pointing to the latest release, but having one where we can easily test is also good. Another thing is that I'm slightly concerned about forgetting to update this when there is a new major... Maybe we can try to automate this but it would be tricky... Honestly I'm a bit torn about this so I think it would be good to discuss it on Slack (I'm out right now but can initiate the discussion on monday)
pull in up to next major, fix build issue