Skip to content

fastlane release_checks: removed call to check_autogenerated_header_up_to_date#1747

Merged
NachoSoto merged 1 commit into
mainfrom
release-checks-check-header
Jul 1, 2022
Merged

fastlane release_checks: removed call to check_autogenerated_header_up_to_date#1747
NachoSoto merged 1 commit into
mainfrom
release-checks-check-header

Conversation

@NachoSoto

@NachoSoto NachoSoto commented Jul 1, 2022

Copy link
Copy Markdown
Contributor

This was added in #1719, but unfortunately it fails when calling ensure_git_status_clean.
So since the header is already automatically generated, we can just go back to the previous behavior and not call this.

…r_up_to_date`

This was added in #1719, but unfortunately [it fails when calling `ensure_git_status_clean`](https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/7379/workflows/f8feaf5d-42f7-4154-8782-9c2f1d36aa6b/jobs/30726).
So since the header is already automatically generated, we can just go back to the previous behavior and not call this.
@NachoSoto NachoSoto requested a review from a team July 1, 2022 16:22
@NachoSoto NachoSoto mentioned this pull request Jul 1, 2022

@tonidero tonidero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm weird... Any idea what files are modified? I will investigate about it next week.

@NachoSoto

Copy link
Copy Markdown
Contributor Author

I'm not sure, it could be fastlane changing the README?

@NachoSoto NachoSoto merged commit 64d157e into main Jul 1, 2022
@NachoSoto NachoSoto deleted the release-checks-check-header branch July 1, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants