Split PurchasesTests step 2: extracted PurchasesConfiguringTests and PurchasesGetCustomerInfoTests#1610
Merged
Merged
Conversation
NachoSoto
commented
May 25, 2022
4ebf11a to
9f3265a
Compare
1f71b94 to
ad5fc4d
Compare
NachoSoto
commented
May 25, 2022
Contributor
Author
There was a problem hiding this comment.
This property made it so that this method wouldn't invoke the callback, which made the tests not actually do anything.
Instead, I've updated the tests to ensure that when the callback is called, the data is correct.
11bb42d to
4890bf9
Compare
aboedo
approved these changes
May 31, 2022
9f3265a to
d32fbe9
Compare
…and `PurchasesGetCustomerInfoTests` Follow up to #1609.
4890bf9 to
f7891e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #1609.