Skip to content

Don't link AdServices.framework on watchOS & tvOS#1554

Merged
NachoSoto merged 2 commits into
ad-servicesfrom
ad-services-watchos
Apr 29, 2022
Merged

Don't link AdServices.framework on watchOS & tvOS#1554
NachoSoto merged 2 commits into
ad-servicesfrom
ad-services-watchos

Conversation

@NachoSoto

@NachoSoto NachoSoto commented Apr 29, 2022

Copy link
Copy Markdown
Contributor

This fixes the watchOS and tvOS compilation (yay CI test coverage catching this!)

Screen Shot 2022-04-29 at 13 35 25

Now the framework is only linked for the rest of the platforms.

@NachoSoto NachoSoto requested review from a team and beylmk April 29, 2022 19:56
@beylmk

beylmk commented Apr 29, 2022

Copy link
Copy Markdown
Contributor

how'd you find this is a problem?

@NachoSoto

NachoSoto commented Apr 29, 2022

Copy link
Copy Markdown
Contributor Author

Oh good question. I built the app locally for watchOS so I could more easily see the build error:

Screen Shot 2022-04-29 at 13 29 26

@beylmk beylmk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 🙏

@NachoSoto NachoSoto changed the title Don't link AdServices.framework on watchOS Don't link AdServices.framework on watchOS & tvOS Apr 29, 2022
@NachoSoto

Copy link
Copy Markdown
Contributor Author

@beylmk updated, I did the same thing for tvOS to make sure that compiles now.

@NachoSoto NachoSoto requested a review from beylmk April 29, 2022 20:36

@beylmk beylmk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 📺 ⌚

@NachoSoto NachoSoto merged commit d9f757b into ad-services Apr 29, 2022
@NachoSoto NachoSoto deleted the ad-services-watchos branch April 29, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants