IntegrationTests: simplified tests using async APIs#1332
Merged
Conversation
04188d2 to
5c5b663
Compare
Improvements: - No more `expect(completed).toEventually(beTrue())`. - No more `expect(error).to(beNil())`. Using `try` and `throws` tests. - No more `expect(result).toNot(beNil())` or `XCTUnwrap`. The new APIs already return non-optional data when not failed. - No more `toEventually`s + polling. Tests run serially now without busy waiting, which will make them faster. - No more completion block trees, tests are linear now. Other changes: - Removed empty optional `purchases(_:, shouldPurchasePromoProduct:, defermentBlock:)`. - Using modern `==` Nimble methods. - Removed redundant `syncPurchases` call when purchasing.
5c5b663 to
51b1e58
Compare
NachoSoto
commented
Feb 22, 2022
| expect(unwrappedOfferings.all).toNot(beEmpty()) | ||
| func testCanGetOfferings() async throws { | ||
| let receivedOfferings = try await Purchases.shared.offerings() | ||
| expect(receivedOfferings.all).toNot(beEmpty()) |
Contributor
Author
There was a problem hiding this comment.
This test is now only 2 lines 🤪
aboedo
approved these changes
Feb 22, 2022
| expect(unwrappedOfferings.all).toNot(beEmpty()) | ||
| func testCanGetOfferings() async throws { | ||
| let receivedOfferings = try await Purchases.shared.offerings() | ||
| expect(receivedOfferings.all).toNot(beEmpty()) |
| expect(completionCalled).toEventually(beTrue(), timeout: Self.timeout) | ||
| let (identifiedCustomerInfo, created) = try await Purchases.shared.logIn(identifiedUserID) | ||
| expect(created) == true | ||
| expect(identifiedCustomerInfo.entitlements["premium"]?.isActive) == true |
Comment on lines
+129
to
+139
| func testLogInReturnsCreatedTrueWhenNewAndFalseWhenExisting() async throws { | ||
| let anonUserID = Purchases.shared.appUserID | ||
| let identifiedUserID = "\(#function)_\(anonUserID)".replacingOccurrences(of: "RCAnonymous", with: "") | ||
|
|
||
| var completionCalled = false | ||
| Purchases.shared.logIn(identifiedUserID) { identifiedCustomerInfo, created, error in | ||
| expect(error).to(beNil()) | ||
| expect(created).to(beTrue()) | ||
| Purchases.shared.logOut { loggedOutCustomerInfo, logOutError in | ||
| Purchases.shared.logIn(identifiedUserID) { identifiedCustomerInfo, created, error in | ||
| expect(error).to(beNil()) | ||
| expect(created).to(beFalse()) | ||
| completionCalled = true | ||
| } | ||
| } | ||
| } | ||
| var (_, created) = try await Purchases.shared.logIn(identifiedUserID) | ||
| expect(created) == true | ||
|
|
||
| expect(completionCalled).toEventually(beTrue(), timeout: Self.timeout) | ||
| _ = try await Purchases.shared.logOut() | ||
|
|
||
| (_, created) = try await Purchases.shared.logIn(identifiedUserID) | ||
| expect(created) == false |
Comment on lines
+211
to
214
| return try await Purchases.shared | ||
| .purchase(package: monthlyPackage) | ||
| .customerInfo | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements:
expect(completed).toEventually(beTrue()).expect(error).to(beNil()). Usingtryandthrowstests.expect(result).toNot(beNil())orXCTUnwrap. The new APIs already return non-optional data when not failed.toEventuallys + polling. Tests run serially now without busy waiting, which will make them faster.Other changes:
purchases(_:, shouldPurchasePromoProduct:, defermentBlock:).==Nimble methods.syncPurchasescall when purchasing.