ProductInfo / ProductInfoExtractorTests refactor#1039
Merged
Conversation
c2c8015 to
08423ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NFC (not functional change)
Just a small refactor while working on #1038, separating here for easier review. Simplifying these will help when adding some new types to
ProductInfo.I'm guessing some of these things are leftovers from the Swift migration.
Changes:
ProductInfoExtractorTests, moved duplicated code intosetUpProductInfoExtractorandISOPeriodFormatter: replaced method with static function: these types contain no data, and there is only one possible implementation that we can have. For that reason, we're not mocking them or injecting them anywhere, so they're simpler as static functions. As an example, we hadlazy var isoPeriodFormatter = ISOPeriodFormatter(), but againISOPeriodFormattercontains no data, only logic, so there's no point having alazyvariable for it.