V4 API updates: added some more changes#1010
Merged
Merged
Conversation
- Added note about `Carthage` integration - Added missing `RevenueCat.ErrorCode.operationAlreadyInProgressForProductError` to Swift section - Added `Package.product` - Fixed `:` in parameter lists - Fixed `PurchasesDelegate` method name - Added error handling section
22f8046 to
be96bc4
Compare
taquitos
reviewed
Nov 30, 2021
| </tbody> | ||
| </table> | ||
|
|
||
| ### Swift Error handling |
696348f to
117e2fa
Compare
|
This pull request has been linked to Shortcut Story #11512: update migration guide to include removal of identity v2. |
Contributor
Author
|
I created one issue for the only missing thing in the TODO list, so I marked this ready for review for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
CarthageintegrationRevenueCat.ErrorCode.operationAlreadyInProgressForProductErrorto Swift sectionPackage.product:in parameter listsPurchasesDelegatemethod namecreateAlias/identify/resetdeprecations ([sc-11512])TODO:
Package.product->Package.productDetailsis now documented here, but this opens another can of worms because of the introduction ofProductDetails:ProductDetails.introductoryPriceis missing: Add support for SK2 discounts #848ProductDetails.subscriptionPeriodis missing: Add subscriptionPeriod support to SK2ProductDetails #849ProductDetails.priceLocaledoesn’t exist, and it looks like StoreKit2'sProductdoesn’t have it: MissingProductDetails.priceLocale#1013ProductDetails.pricechanged fromNSDecimalNumbertoDecimal, not documented