Skip to content

Added subscription period and free trial period parsing for Amazon#884

Merged
joshdholtz merged 2 commits into
amazon-store-productfrom
amazon-store-product-period
Mar 20, 2023
Merged

Added subscription period and free trial period parsing for Amazon#884
joshdholtz merged 2 commits into
amazon-store-productfrom
amazon-store-product-period

Conversation

@joshdholtz

@joshdholtz joshdholtz commented Mar 17, 2023

Copy link
Copy Markdown
Member

Motivation

CF-1288

Description

Parses Amazon's English language period durations into a Period object and an ISO 8601 string 💪

@joshdholtz joshdholtz requested review from beylmk and vegaro March 17, 2023 19:37
@joshdholtz joshdholtz added the pr:feat A new feature label Mar 17, 2023

@beylmk beylmk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏴󠁧󠁢󠁥󠁮󠁧󠁿 thank you!

@joshdholtz joshdholtz merged commit b91a6f3 into amazon-store-product Mar 20, 2023
@joshdholtz joshdholtz deleted the amazon-store-product-period branch March 20, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:feat A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants