Rename verification result SUCCESS to VERIFIED#874
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #874 +/- ##
==========================================
+ Coverage 83.28% 83.31% +0.02%
==========================================
Files 139 139
Lines 4548 4548
Branches 602 602
==========================================
+ Hits 3788 3789 +1
Misses 540 540
+ Partials 220 219 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
NachoSoto
approved these changes
Mar 15, 2023
NachoSoto
reviewed
Mar 15, 2023
| @@ -21,7 +21,7 @@ enum class VerificationResult { | |||
| /** | |||
| * Entitlements were verified with our server. | |||
Contributor
There was a problem hiding this comment.
I wouldn't mention entitlements here since this type can be used for any response.
Contributor
Author
There was a problem hiding this comment.
Hmm good point... We should also update the other enum values and iOS @NachoSoto
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR renames
VerificationResult.SUCCESStoVerificationResult.VERIFIED. This is to match iOS nomenclature.