Updating comment for syncPurchases#763
Conversation
Updating comment for syncPurchases as there was some confusion with previous version stating that it could be called after each purchase.
|
Should I update this in purchases-ios and hybrids as well? And how can I get the changes to propagate to the public sdk reference? https://sdk.revenuecat.com/android/5.0.0/purchases/com.revenuecat.purchases/-purchases/sync-purchases.html @aboedo @vegaro |
|
Also not sure why the test failed, I don't think I did anything? 😣 |
|
@HaleyRevcat the test failed because of this:
We use labels to categorize changes in changelogs, like "new features", "bug fixes", etc. Updating in other repos would be great! I think iOS is okay, but I haven't checked the hybrids. |
| * for subscriptions anytime a sync is needed, like after a successful purchase, or when migrating existing | ||
| * users to RevenueCat | ||
| * for subscriptions anytime a sync is needed, such as when migrating existing users to RevenueCat | ||
| * |
There was a problem hiding this comment.
Not sure what's going on with the thing it's complaining about from line 1, but it's safe to ignore since it wasn't modified in this PR.
The other one, however, is from this PR, and it's complaining about this extra line (217), since we'd have two consecutive lines that have nothing in it.
Could you remove line 217?
|
@aboedo I got rid of line 217, can this be merged? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #763 +/- ##
=======================================
Coverage 81.54% 81.54%
=======================================
Files 121 121
Lines 3999 3999
Branches 512 512
=======================================
Hits 3261 3261
Misses 535 535
Partials 203 203 ☔ View full report in Codecov by Sentry. |
|
yes! marking as ready for review and merging |
Updating comment for syncPurchases as there was some confusion with previous version stating that it could be called after each purchase.
Checklist
purchases-iosand hybridsMotivation
Confusion with usage of syncPurchases, such as [here](https://community.revenuecat.com/sdks-51/when-should-i-call-syncpurchases-2502?postid=7942#post7942)Description
Updated comment