Pass $CIRCLE_BRANCH to prepare_next_version#583
Merged
Merged
Conversation
NachoSoto
approved these changes
Aug 5, 2022
NachoSoto
left a comment
Contributor
There was a problem hiding this comment.
I think this makes sense 👍🏻
We don't want to make fastlane read such a specific environment variable.
tonidero
approved these changes
Aug 5, 2022
Contributor
|
Yeah I think this solution makes sense. Additionally, we probably want to make the branch parameter for this action non-optional and not default to anything in the plugin. I thought we were creating the tag from main, but it's true it's safer to create the tag from the branch. I will change that on monday and remove the default to main here. Thanks for fixing this! |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves SDKONCALL-84
It seems that CircleCI is calling:
prepare_next_versionwith no options, so the check here:branch: options[:branch] || 'main'is falling back to main. When we're deploying from a tag, we're not on main.