[CSDK-302] Fix: attempt to reconnect when billing response is error#558
Merged
Conversation
NachoSoto
reviewed
Jul 11, 2022
NachoSoto
left a comment
Contributor
There was a problem hiding this comment.
This makes a lot of sense to me 👍🏻
Merged
tonidero
reviewed
Jul 18, 2022
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Just a question, but I think it shouldn't matter in this case
| BillingClient.BillingResponseCode.SERVICE_TIMEOUT, | ||
| BillingClient.BillingResponseCode.ERROR, | ||
| BillingClient.BillingResponseCode.SERVICE_UNAVAILABLE, | ||
| BillingClient.BillingResponseCode.USER_CANCELED, |
Contributor
There was a problem hiding this comment.
Hmm should we retry on a USER_CANCELED response code? Though I guess we shouldn't get this code in the onBillingSetupFinished callback and this is just to complete the cases, seems like it could be part of the codes where we don't retry? Just would like to understand why it was put here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking our code against Google's example, it strikes me that there are a couple of instances where we're not actively retrying the connection, but Google is (and it seems reasonable).
So I added those cases.
https://revenuecats.atlassian.net/browse/CSDK-302
Another attempt at solving #553