Support for fastlane-plugin-revenuecat_internal#557
Merged
Conversation
1 task
c87087d to
c9666ab
Compare
2d5e09f to
23594f7
Compare
tonidero
commented
Aug 3, 2022
tonidero
left a comment
Contributor
Author
There was a problem hiding this comment.
This is now final @RevenueCat/sdk
| @@ -1,3 +1,9 @@ | |||
| GIT | |||
| remote: https://github.com/RevenueCat/fastlane-plugin-revenuecat_internal | |||
| revision: 94bad7a0ea1494f82973d34dfe9647963d873ad0 | |||
Contributor
Author
There was a problem hiding this comment.
This can be updated with bundle update fastlane-plugin-revenuecat_internal
| desc "Upload and close a release" | ||
| lane :deploy do |options| | ||
| version = android_get_version_name(gradle_file: gradle_file_path) | ||
| version = current_version_number |
Contributor
Author
There was a problem hiding this comment.
I changed to use a .version instead of getting the version directly from gradle. I think this is good to make all our SDKs consistent since this is platform agnostic but do lmk if you think otherwise.
vegaro
approved these changes
Aug 3, 2022
aboedo
approved these changes
Aug 3, 2022
| desc "Upload and close a release" | ||
| lane :deploy do |options| | ||
| version = android_get_version_name(gradle_file: gradle_file_path) | ||
| version = current_version_number |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR provides support to use the fastlane revenuecat internal plugin to share automation logic between SDKs. Currently the
bump,github_releaseandprepare_next_versionlanes use the plugin.TODO: