Upgrade Android Gradle Plugin and Kotlin versions#474
Conversation
|
@vegaro what's the status of this one? |
|
I got stuck with an issue that I couldn't solve and decided to keep it here until I had some time to come back to it. I will rebase and see if it keeps happening and maybe with the help of @tonidero we can upgrade our dependencies |
|
Alright, I am blocked again @tonidero . Looks like there's an issue with purchase_tester that it's not generating R, but I can't spot it. Locally I have memory issues too. I have created a task in Jira. This is not high priority at all, but if you want to take a look at it one day that you want to work on something different, feel free to work on this branch. I tend to come back to it on Fridays lol |
|
Sounds good! Will take a look at it when I have some time. Thanks! |
|
Little update, I managed to fix the Integration tests fail for reasons I still don't know... |
|
@vegaro I wanted to ask for an update on this. I was thinking about picking this one up in order to work on https://revenuecats.atlassian.net/browse/CSDK-334 since updating the lifecycle library requires updating the compileVersion, which you're already doing here. I checked this branch and integration tests are running fine for me. Did you run into any other issues? |
|
Also, tests took < 6min to run for me, which is approximately the same they took before for me. |
| maxHeapSize = "1024m" | ||
| } | ||
| } | ||
| namespace 'com.revenuecat.api_tester_kotlin' |
There was a problem hiding this comment.
Hmm it's weird this is needed now... Afaik, this should be the same as the package of the module by default... Was this due to the R file collision you mentioned?
There was a problem hiding this comment.
This was from an automatic migration to the latest AGP version. Maybe it's not mandatory?
There was a problem hiding this comment.
Oh interesting... Maybe it's needed if applicationId is not set? I thought it would automatically pick the package name and use that as the namespace but it's possible you need to set one or the other. I will take another look. In any case, I'm ok with this change!
| plugins { | ||
| id "io.gitlab.arturbosch.detekt" version "1.17.0-RC3" | ||
| id "com.savvasdalkitsis.module-dependency-graph" version "0.9" | ||
| id "com.github.ben-manes.versions" version "0.42.0" |
There was a problem hiding this comment.
I was wondering how are you planning to use this plugin? Looks like it can be a useful tool to keep things updated, so not sure if we should add it's tasks somewhere...
There was a problem hiding this comment.
I was thinking about including some sort of automation that automatically upgrades dependencies instead of this plugin. I used this one to fix a couple issues I was having but I don't think we have to merge it into main
|
|
||
| android { | ||
| compileSdkVersion 30 | ||
| compileSdkVersion 31 |
There was a problem hiding this comment.
We can probably use the compileVersion here? Not sure if we want to link it to the sdk, but I think that's ok?
| unityIAPApi "com.android.billingclient:billing:$billingClient3Version" | ||
| implementation "androidx.lifecycle:lifecycle-runtime:$lifecycleVersion" | ||
| kapt "androidx.lifecycle:lifecycle-compiler:$lifecycleVersion" | ||
| implementation "androidx.lifecycle:lifecycle-common-java8:$lifecycleVersion" |
There was a problem hiding this comment.
I believe you can remove the -java8 suffix, since everything was moved to the lifecycle-common dependency
There was a problem hiding this comment.
We are not using the common build.gradle for the MagicWeather app, so I had to duplicate the versions here... We could have tried to import it, but considering that one has things related to the SDK, it felt better to keep it separate.
There was a problem hiding this comment.
Yeah I think it's because it's not part of the project
There was a problem hiding this comment.
Changes here are related to https://revenuecats.atlassian.net/browse/CSDK-334
There was a problem hiding this comment.
Latest is actually 1.7.10. I'm planning to merge this and update it further on future PRs.
fix compilation error upgrades to 7.2
From Toni:
Taking over this PR. This will update a bunch of our dependencies versions. None of them should cause breaking changes for our users. Additionally, this will deal with https://revenuecats.atlassian.net/browse/CSDK-334