Fix galaxy module deployment#3203
Conversation
📸 Snapshot TestBase build not foundNo build was found for the base commit 873e25f. This is required to generate a snapshot diff for your pull request. It's possible that you created a branch off the base commit before all of the CI steps have finished processing, e.g. the one that uploads a build to our system. If that's the case, no problem! Just wait and this will eventually resolve. 🛸 Powered by Emerge Tools |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Snapshot deploy job missing Samsung AAR download step
- Added the missing
downloadSamsungIapAarstep to thedeploy-snapshotCircleCI job so:feature:galaxyis included beforedeploy_snapshotruns.
- Added the missing
Or push these changes by commenting:
@cursor push 9d0b7e0fe6
Preview (9d0b7e0fe6)
diff --git a/.circleci/config.yml b/.circleci/config.yml
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -482,6 +482,10 @@
cache_prefix: v1a
- prepare-signing-key
- run:
+ name: Download Samsung IAP SDK AAR
+ command: |
+ ./gradlew downloadSamsungIapAar --no-daemon
+ - run:
name: Deployment
command: |
bundle exec fastlane android deploy_snapshot| - run: | ||
| name: Download Samsung IAP SDK AAR | ||
| command: | | ||
| ./gradlew downloadSamsungIapAar --no-daemon |
There was a problem hiding this comment.
Snapshot deploy job missing Samsung AAR download step
High Severity
The deploy-snapshot CI job calls fastlane android deploy_snapshot, which invokes the deploy lane that now includes the new feature:galaxy BC7 publish step. However, unlike the deploy job, deploy-snapshot does not run downloadSamsungIapAar beforehand. Without the AAR, settings.gradle.kts won't include :feature:galaxy, so the feature:galaxy:publish Gradle task will fail, breaking all snapshot deployments.
Additional Locations (1)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## samsung-dev #3203 +/- ##
============================================
Coverage 79.19% 79.19%
============================================
Files 356 356
Lines 14272 14272
Branches 1945 1945
============================================
Hits 11302 11302
Misses 2165 2165
Partials 805 805 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tonidero
left a comment
There was a problem hiding this comment.
Looking good! Just something I don't think we need + a question
Description
The release of the
9.23.1-galaxy-beta.1didn't break, but it didn't truly succeed either. While the main and amazon modules were published, nopurchases-store-galaxymodule was ever published. I believe this is because the release job never downloaded the Samsung IAP AAR, so:feature:galaxywas not included during Gradle configuration. That meant the root publish task had no galaxy module to publish.There was also no explicit BC7 galaxy publish step in Fastlane, unlike amazon.
This change fixes both issues by downloading the Samsung AAR in the deploy job before publishing, and by adding a dedicated
feature:galaxyBC7 publication step.Link to the deploy job in question: https://app.circleci.com/pipelines/github/RevenueCat/purchases-android/20121/workflows/ec6f8c48-734b-427c-84f7-b0558311d74f/jobs/156314
Note
Medium Risk
Touches CI/release publishing flow; while the change is small, mistakes could cause missing or broken Maven publications for Galaxy releases.
Overview
Fixes Galaxy module publishing in release deploys. The CircleCI
deployjob now downloads the Samsung IAP SDK AAR before runningfastlane android deploy, ensuring the Galaxy Gradle module is configured and eligible for publishing.Fastlane’s
deploylane now also publishes a dedicated Billing Client 7 Galaxy artifact (purchases-store-galaxy-bc7) viafeature:galaxy, mirroring the existing Amazon BC7 publish step.Written by Cursor Bugbot for commit 651026f. This will update automatically on new commits. Configure here.