Add backward-compat deserialization tests for legacy offer conditions#3172
Merged
Merged
Conversation
Verifies that old-format JSON with extra operator+value fields
(e.g. {"type": "intro_offer", "operator": "=", "value": true})
correctly deserializes to the plain IntroOffer/PromoOffer objects,
silently ignoring the extra fields.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vegaro
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
operator+valuefields (e.g.{"type": "intro_offer", "operator": "=", "value": true}) correctly deserializes to the plainIntroOffer/PromoOfferobjects, silently ignoring the extra fields.Test plan
ComponentOverridesTestspass🤖 Generated with Claude Code
Note
Low Risk
Low risk: test-only change that adds coverage for backward-compatible JSON deserialization behavior without modifying production code.
Overview
Adds parameterized test cases in
ComponentOverridesTeststo verify backward compatibility: legacyintro_offer/promo_offercondition JSON that includes extraoperator/valuefields is accepted and deserializes toCondition.IntroOffer/Condition.PromoOffer(silently ignoring the extra fields).Written by Cursor Bugbot for commit 2a1a829. This will update automatically on new commits. Configure here.