[Conditional Configurability] More tests#3156
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| text = stackChildTextKey, | ||
| color = textColor, | ||
| visible = false, | ||
| ) |
There was a problem hiding this comment.
Test child component visibility wrong, vacuously passes
Medium Severity
The test Parent stack hidden overrides child visible override is meant to verify that a hidden parent overrides a child's visible=true state, as stated in the doc comment ("even if the child has its own override setting visible=true"). However, childText is constructed with visible = false and has no override to make it visible. This means assertDoesNotExist() at the end vacuously passes — the child was never going to appear regardless of the parent's visibility logic. If the parent-hides-children propagation is ever broken, this test will not catch it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## cesar/conditional-configurability #3156 +/- ##
==================================================================
Coverage 79.23% 79.23%
==================================================================
Files 347 347
Lines 13930 13930
Branches 1889 1889
==================================================================
Hits 11038 11038
Misses 2109 2109
Partials 783 783 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Note
Low Risk
Test-only changes that broaden coverage for conditional override evaluation and compose visibility; minimal risk beyond potential CI/runtime cost from added UI tests.
Overview
Expands
BuildPresentedPartialTeststo cover more edge cases in override selection/merging, including last-match wins behavior,intro_offer/promo_offeroperator handling (equals/not_equals), and variable type-mismatch scenarios.Adds a large new
VisibilityConditionTestssuite exercising Compose rendering for conditional visibility/styling across components (carousel/timeline/video/text/stack/tabs), including interactions driven byselected_package, sibling independence, and footer/body cross-effects.Updates test helpers (
FakePaywallState, testtoComponentsPaywallState) to support injectingcustomVariablesand astickyFooterso the new UI tests can build realistic states.Written by Cursor Bugbot for commit c0c5ed6. This will update automatically on new commits. Configure here.