[Conditional Configurability] Add support for Booleans y Numbers#3143
Merged
vegaro merged 1 commit intoFeb 26, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## cesar/conditional-configurability #3143 +/- ##
==================================================================
Coverage 79.22% 79.22%
==================================================================
Files 347 347
Lines 13948 13948
Branches 1893 1893
==================================================================
Hits 11050 11050
Misses 2112 2112
Partials 786 786 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tonidero
approved these changes
Feb 26, 2026
tonidero
left a comment
Contributor
There was a problem hiding this comment.
I think this looks great! 🚢
5681684
into
cesar/conditional-configurability
28 of 29 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were missing support for boolean and number custom variables
Note
Medium Risk
Public API surface changes by making
CustomVariableValue.NumberandCustomVariableValue.Booleanpublicly constructible and updating call sites to use typed values, which could affect downstream integrations and string formatting expectations.Overview
Adds first-class support for numeric and boolean custom paywall variables by making
CustomVariableValue.NumberandCustomVariableValue.Booleanpublic and exporting them in the public API (api.txt).Updates the tester apps and examples to construct and pass typed
Number/Booleanvalues (instead of stringifying), including the custom variables editor dialog’s value creation logic and sampleCUSTOM_VARIABLES/API tests.Written by Cursor Bugbot for commit 84aec0f. This will update automatically on new commits. Configure here.