Skip to content

Implement GalaxyOfferingParser#2926

Merged
fire-at-will merged 1 commit into
samsung-devfrom
galaxy-offering-parser
Dec 12, 2025
Merged

Implement GalaxyOfferingParser#2926
fire-at-will merged 1 commit into
samsung-devfrom
galaxy-offering-parser

Conversation

@fire-at-will

Copy link
Copy Markdown
Contributor

Description

Without an offering parser for the Galaxy Store, the SDK will crash when configured with the Galaxy Store. This PR adds and registers a GalaxyOfferingParser, which has an implementation identical to the AmazonOfferingParser, since the Galaxy Store's products just have a product ID and no options.

In a follow-up PR into main, we should remove the reflection used to instantiate the AmazonOfferingParser.

@fire-at-will fire-at-will self-assigned this Dec 12, 2025
@fire-at-will fire-at-will requested a review from a team as a code owner December 12, 2025 17:32
@fire-at-will fire-at-will added the pr:feat A new feature label Dec 12, 2025
@fire-at-will fire-at-will merged commit 63bb139 into samsung-dev Dec 12, 2025
4 of 19 checks passed
@fire-at-will fire-at-will deleted the galaxy-offering-parser branch December 12, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:feat A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants