Galaxy Scaffolding Classes#2901
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## samsung-dev #2901 +/- ##
===============================================
- Coverage 78.46% 78.36% -0.10%
===============================================
Files 332 335 +3
Lines 12880 12926 +46
Branches 1749 1751 +2
===============================================
+ Hits 10106 10130 +24
- Misses 2040 2061 +21
- Partials 734 735 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| override val name: String, | ||
|
|
||
| /** | ||
| * Name of the product. This will match the name for Galaxy products. |
There was a problem hiding this comment.
This is not a typo: ProductVos do not have a title property, so we'll need to just put the name property in here (or leave it as a blank string)
| import com.revenuecat.purchases.models.PurchasingData | ||
| import dev.drewhamilton.poko.Poko | ||
|
|
||
| sealed class GalaxyPurchasingData : PurchasingData { |
There was a problem hiding this comment.
Same as in the preview PR, might make sense to make these experimental... but NABD since we're merging to an integration branch
| override val price: Price, | ||
|
|
||
| /** | ||
| * Name of the product. This will match the name for Galaxy products. |
There was a problem hiding this comment.
A bit weird doc, saying that it will match itself :P Probably not needed? Like
| * Name of the product. This will match the name for Galaxy products. | |
| * Name of the product. |
Description
Introduces the scaffolding for several classes that will be foundational to Samsung development as we move forward:
GalaxyBillingWrapper: implementation ofBillingAbstract. The class currently satisfies all of the BillingAbstract's requirements, but all functions are stubbed withTODOsGalaxyPurchasingData: will be used when processing samsung purchasesGalaxyStoreProduct: represents a product from the Samsung store