Skip to content

Add Galaxy Store#2900

Merged
fire-at-will merged 6 commits into
samsung-devfrom
add-samsung-storetype
Dec 8, 2025
Merged

Add Galaxy Store#2900
fire-at-will merged 6 commits into
samsung-devfrom
add-samsung-storetype

Conversation

@fire-at-will

@fire-at-will fire-at-will commented Dec 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adds the GALAXY to the list of supported Store types.

Note: This PR will have one failing integration test for the Customer Center's localized strings not containing the Galaxy Store string until a backend PR has been merged.

@fire-at-will fire-at-will requested review from a team as code owners December 5, 2025 20:03
@fire-at-will fire-at-will added the pr:feat A new feature label Dec 5, 2025
@fire-at-will fire-at-will requested a review from tonidero December 7, 2025 19:46
@fire-at-will fire-at-will changed the title Add SAMSUNG_STORE Store Add Galaxy Store Dec 8, 2025
fire-at-will
fire-at-will commented Dec 8, 2025
View reviewed changes
Comment thread purchases/src/main/kotlin/com/revenuecat/purchases/customercenter/CustomerCenterConfigData.kt
AMAZON_STORE,

@SerialName("galaxy_store")
GALAXY_STORE,

@fire-at-will fire-at-will Dec 8, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Named this GALAXY_STORE instead of galaxy since the string is literally "Galaxy Store" to match the name of the store

@codecov

codecov Bot commented Dec 8, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.46%. Comparing base (8151db5) to head (e17210c).
⚠️ Report is 4 commits behind head on samsung-dev.

Files with missing lines Patch % Lines
...rchases/customercenter/CustomerCenterConfigData.kt 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           samsung-dev    #2900   +/-   ##
============================================
  Coverage        78.46%   78.46%           
============================================
  Files              332      332           
  Lines            12880    12885    +5     
  Branches          1749     1749           
============================================
+ Hits             10106    10110    +4     
- Misses            2040     2041    +1     
  Partials           734      734

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fire-at-will fire-at-will merged commit 6269541 into samsung-dev Dec 8, 2025
23 checks passed
@fire-at-will fire-at-will deleted the add-samsung-storetype branch December 8, 2025 15:21
tonidero
tonidero reviewed Dec 9, 2025
View reviewed changes
Comment thread purchases/src/main/kotlin/com/revenuecat/purchases/EntitlementInfo.kt
/**
* For entitlement granted via the Galaxy store.
*/
GALAXY,

@tonidero tonidero Dec 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit late but should we mark this enum value as Experimental? I guess it could still be considered a small breaking change for devs using switch-case statements... NABD for now since we're merging to an integration branch though :)

This was referenced Mar 12, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonidero tonidero tonidero left review comments

@MarkVillacampa MarkVillacampa MarkVillacampa approved these changes

Assignees

No one assigned

Labels

pr:feat A new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fire-at-will @tonidero @MarkVillacampa