Skip to content

Fallback to Billing library when error querying products through AIDL#2898

Merged
tonidero merged 3 commits into
add-aidl-querying-purchase-history-in-appfrom
aidl-fallback-to-billing-library-on-errors
Dec 5, 2025
Merged

Fallback to Billing library when error querying products through AIDL#2898
tonidero merged 3 commits into
add-aidl-querying-purchase-history-in-appfrom
aidl-fallback-to-billing-library-on-errors

Conversation

@tonidero

@tonidero tonidero commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

Description

This is based on #2872

This just makes sure we correctly handle issues when querying products through the AIDL, by falling back to the billing library mechanisms.

@tonidero tonidero marked this pull request as ready for review December 5, 2025 08:44
@tonidero tonidero requested a review from a team as a code owner December 5, 2025 08:44

@rickvdl rickvdl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! Change looks good to me, might be good to have another set of eyes on it just to be sure.

@ajpallares ajpallares left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right! Makes total sense! 👍

@codecov

codecov Bot commented Dec 5, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.82%. Comparing base (efd72ff) to head (ca29974).
⚠️ Report is 1 commits behind head on add-aidl-querying-purchase-history-in-app.

Files with missing lines Patch % Lines
.../com/revenuecat/purchases/google/BillingWrapper.kt 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                              Coverage Diff                              @@
##           add-aidl-querying-purchase-history-in-app    #2898      +/-   ##
=============================================================================
- Coverage                                      78.83%   78.82%   -0.01%     
=============================================================================
  Files                                            337      337              
  Lines                                          13105    13108       +3     
  Branches                                        1764     1765       +1     
=============================================================================
+ Hits                                           10331    10333       +2     
  Misses                                          2035     2035              
- Partials                                         739      740       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tonidero tonidero merged commit 5f3b4bd into add-aidl-querying-purchase-history-in-app Dec 5, 2025
23 checks passed
@tonidero tonidero deleted the aidl-fallback-to-billing-library-on-errors branch December 5, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants